[DJI-log-discuss] patch proposition

[Peter Felecan]

On Thu 16 Apr 2020 at 11:50, Ross Finlayson <finlayson at live555.com> wrote:

> No, I won’t be adding “-Werror” to the installed Makefile.  If anyone
> wants “-Werror”, then they will know how to edit the Makefile to add it.
> (By the way, you might wish to read:
> https://embeddedartistry.com/blog/2017/05/22/werror-is-not-your-friend/ )


Read and understood even though I prefer the proposed mechanism, in the
article, to inhibit the feature when in a hurry. But let’s put this aside
for other venues.

In the next released version of the source code, however, I’ll make many of
> the other changes that you propose, including changing
>         %lld
> to
>         %llu
> and
>         %ld
> to
>         %lu


Okay

where appropriate.  I won’t, however, be changing
>         %lld (or %llu)
> to
>         %lu
> because that generates warning messages (for 64-bit values) with the
> compiler that I (and, I presume, many other people) use.


Strange, can you, just for my curiosity tell what compiler/tool chain do
you use and think that other people use ?

Thank you for your work. If I can provide new data or test cases, do not
hesitate; over the time I have access to various models from DJI, new as
old.
-- 
Peter Felecan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://ns.live555.com/pipermail/dji-log-discuss/attachments/20200416/fbb68669/attachment.htm>